Try to avoid static symbols if leaving them would make a leak #15548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
requested changes
Jul 5, 2022
smarter
reviewed
Jul 6, 2022
| @@ -512,7 +512,7 @@ object TypeOps: | |||
| @threadUnsafe lazy val forbidden = symsToAvoid.toSet | |||
| def toAvoid(tp: NamedType) = | |||
| val sym = tp.symbol | |||
| !sym.isStatic && forbidden.contains(sym) | |||
There was a problem hiding this comment.
But shouldn't the anonymous subclass be considered non-static since it's declared in a block? I assume the issue is that its owner is set to the top-level scope, but if we can't change its owner we could perhaps special case ANON_CLASS in SymDenotation#isStatic
|
@odersky It seems that removing the @smarter I checked and adding a special case for ANON_CLASS also doesn't break anything. But shouldn't it actually be static though, since it's owner is static? If so then someone can potentially rely on this check in the future. |
odersky
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #9314
Typer.ensureNoLocalRefs doesn't avoid local static refs like anonymous
class instances to allow typing more specific expected types with e.g. refinements.
Unfortunately this can cause leaks when expected types have to be
inferred. This PR tries to fix this problem by adding a fallback that
avoids all local symbols if this leak were to happen.